Closed asmundu closed 1 year ago
Hi @asmundu thank you for creating this PR! We will be merging this in this sprint 😄
Hi @asmundu thank you so much for your contribution! I have merged your PR into this branch here.
Hi @asmundu thank you so much for your contribution! I have merged your PR into this branch here.
Thanks a lot!
This PR has been merged into the latest release
Are you a current Fivetran customer?
Åsmund Ueland - Data Engineer at Oda.
What change(s) does this PR introduce?
Added the column currency_code to the five (out of six) models that were missing this (google_ads__ad_group_report, google_ads__ad_report, google_ads__campaign_report, google_ads__keyword_report and google_ads__url_report). All of these models had spend in them.
Did you update the CHANGELOG?
Does this PR introduce a breaking change?
Addition of a new column does not break models (unless one uses
select * from
(which one shouldn't). Also, I believe the _currencycode should be 1-to-1 with _accountid (and even if it is not, when a model has spend in it, you would want to know the currency of that spend).Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
Yes, but it was submitted through your Feedback Form.
How did you test the PR changes?
I re-ran all the changed model in my local dbt setup, using our own data/database after changing the package reference to my local edited version of the dbt package dbt_google_ads. They all ran successfully.
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
:partying_face: **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.