fivetran-jamie
commented
1 year ago we've figured this out (we did indeed need to pull the stats IDs rather than the history table ones due to Google hard-deleting entities from history tables but retaining them in the stats models
Is there an existing issue for this?
Describe the issue
The hotfix for this PR needs to be investigated more in depth. For some reason, this package was passing in every warehouse in Buildkite except for Databricks. A hotfix was implemented so that integration testing can pass in order to not block this PR for Ad Reporting. However, it is uncertain if the issue stemmed from the Databricks implementation or if the model(s) themselves should be updated. The hotfix was to move the Ad Report's join from using the history table for Ad ID to use the stats table for Ad ID.
This ticket's purpose is to investigate this issue further and implement a long term fix for this issue. Whether that be updating the join logic such that we are pulling only from the respective stats tables for all of our models in this package (similar to Microsoft Ads), fixing the Databricks implementation or something else.
Relevant error log or model output
No response
Expected behavior
Details in the issue description.
dbt Project configurations
dbt google ads 0.8.0
Package versions
N/A
What database are you using dbt with?
databricks
dbt Version
1.3
Additional Context
No response
Are you willing to open a PR to help address this issue?