fivetran / dbt_google_ads

Fivetran data transformations for Google Ads built using dbt.
https://fivetran.github.io/dbt_google_ads/
Apache License 2.0
13 stars 29 forks source link

Adjust join key on key word report #41

Closed jkokatjuhhavoila closed 1 year ago

jkokatjuhhavoila commented 1 year ago

Are you a current Fivetran customer?

Jekaterina Kokatjuhha, interim Data Lead, getvoila What change(s) does this PR introduce?

Adjusted keyword report to leverage the stats ids as opposed to the history ids to have more accurate reporting. Did you update the CHANGELOG?

Does this PR introduce a breaking change?

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

Is this PR in response to a previously created Bug or Feature Request

How did you test the PR changes?

Select which warehouse(s) were used to test the PR

Provide an emoji that best describes your current mood

:dancer: **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.
jkokatjuhhavoila commented 1 year ago

Tested, everything works as it should! Thank you!

fivetran-joemarkiewicz commented 1 year ago

Tested, everything works as it should! Thank you!

Sounds great, thanks for testing! I will kick off our internal merge and release process 😄