search

fivetran / dbt_google_ads

Fivetran data transformations for Google Ads built using dbt.
https://fivetran.github.io/dbt_google_ads/
Apache License 2.0
13 stars 29 forks source link

[Feature]Request to add currency type to reporting tables #43

Open jbradysmith opened 1 year ago

jbradysmith commented 1 year ago

Is there an existing feature request for this?

Describe the Feature

The output tables in the google_ads reporting tables have a spend column, but we need to know what they currency type is USD, CAN, etc.) so that we can convert the value based on a currency conversion factor.

Describe alternatives you've considered

Writing the same report as a view in sql.

Are you interested in contributing this feature?

Anything else?

No response

fivetran-joemarkiewicz commented 1 year ago

Hi @jbradysmith thank you for opening this feature request!

I think the request you are suggesting is very valid and most likely relevant for the majority of our other users. Particularly I think this would be valuable for customers leveraging the secondary currencies feature within Google Ads. Can you confirm that you are using the secondary currency feature in Google Ads, and that is the primary need for adding the currency in these models?

jbradysmith commented 1 year ago

This is not the secondary currencies feature. That is a Google Ads 360 feature. From the front end of GA, at the manager account level I am able to toggle on a "layer" that converts currency from CAD to USD, and I can build reports that use "converted currency" as a value. Thats the functionality I want to archive. This is available in the dbt Bing tables. I am happy to add these comments to the other thread, its just locked for me

From: Joe Markiewicz @.> Sent: Monday, February 27, 2023 10:03 AM To: fivetran/dbt_google_ads @.> Cc: Brady Smith @.>; Mention @.> Subject: Re: [fivetran/dbt_google_ads] [Feature]Request to add currency type to reporting tables (Issue #43)

Hi @jbradysmithhttps://github.com/jbradysmith thank you for opening this feature request!

I think the request you are suggesting is very valid and most likely relevant for the majority of our other users. Particularly I think this would be valuable for customers leveraging the secondary currencies feature within Google Ads. Can you confirm that you are using the secondary currency feature in Google Ads, and that is the primary need for adding the currency in these models?

— Reply to this email directly, view it on GitHubhttps://github.com/fivetran/dbt_google_ads/issues/43#issuecomment-1446597221, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFIJLGQ4JJZK3OMVW3RC6CTWZTF3RANCNFSM6AAAAAAVF2SENE. You are receiving this because you were mentioned.Message ID: @.***>