search

fivetran / dbt_google_ads

Fivetran data transformations for Google Ads built using dbt.
https://fivetran.github.io/dbt_google_ads/
Apache License 2.0
13 stars 29 forks source link

[Feature] Add currency type to ad reporting #44

Open jbradysmith opened 1 year ago

jbradysmith commented 1 year ago

Is there an existing feature request for this?

Describe the Feature

Described here, but I cannot add comments to the thread :( https://github.com/fivetran/dbt_google_ads/issues/43

This is not the secondary currencies feature. That is a Google Ads 360 feature. From the front end of GA, at the manager account level I am able to toggle on a "layer" that converts currency from CAD to USD, and I can build reports that use "converted currency" as a value. Thats the functionality I want to archive. This is available in the dbt Bing tables. I am happy to add these comments to the other thread, its just locked for me

Describe alternatives you've considered

na

Are you interested in contributing this feature?

Anything else?

No response

fivetran-joemarkiewicz commented 1 year ago

Described here, but I cannot add comments to the thread :(

That is strange 🤔. The thread isn't locked and you should be able to add comments without an issue. If possible, it would be great to keep the thread in the initial feature request. If not, I hope you are able to reply here!

Your note makes sense to me that this isn't a secondary currency but just wanting the base currency to be included in the reports. Based on my quick investigation into the Google Ads data, it seems currency is only available within the account_history table. Is it safe to assume in your opinion that mapping the currency from the account level to the corresponding reports would tell an accurate currency story for your Google Ads data, and achieve the intended result you are looking to attain?

jbradysmith commented 1 year ago

Let me do some testing on my side to confirm that.

Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Joe Markiewicz @.> Sent: Tuesday, February 28, 2023 11:05:07 AM To: fivetran/dbt_google_ads @.> Cc: Brady Smith @.>; Author @.> Subject: Re: [fivetran/dbt_google_ads] [Feature] Add currency type to ad reporting (Issue #44)

Described here, but I cannot add comments to the thread :(

That is strange 🤔. The thread isn't locked and you should be able to add comments without an issue. If possible, it would be great to keep the thread in the initial feature request. If not, I hope you are able to reply here!

Your note makes sense to me that this isn't a secondary currency but just wanting the base currency to be included in the reports. Based on my quick investigation into the Google Ads data, it seems currency is only available within the account_history table. Is it safe to assume in your opinion that mapping the currency from the account level to the corresponding reports would tell an accurate currency story for your Google Ads data, and achieve the intended result you are looking to attain?

— Reply to this email directly, view it on GitHubhttps://github.com/fivetran/dbt_google_ads/issues/44#issuecomment-1448537370, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFIJLGQY335WL5Q7LJW6YETWZYV4HANCNFSM6AAAAAAVK7JSPE. You are receiving this because you authored the thread.Message ID: @.***>