Closed fivetran-reneeli closed 1 year ago
This PR will address the following Issue/Feature: Issue #48
Applying the changes from @asmundu's PR https://github.com/fivetran/dbt_google_ads/pull/36 to most recent version of our google ads package.
This PR will result in the following new package version: v0.9.2
v0.9.2
This is adding a new field and does not affect downstream models, therefore will not be a breaking change.
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
This PR adds the currency_code field to the following models: google_ads__ad_group_report.sql google_ads__ad_report.sql google_ads__campaign_report.sql google_ads__keyword_report.sql google_ads__url_report.sql
currency_code
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
After running the models I now see currency_code as an added field. Example compiled code below:
Outputted models in target warehouse now have the additional field:
Please acknowledge that your PR contains the following standard updates:
Please acknowledge that after the above were all completed the below were applied to your branch:
Looks like BuildKite is passing!
awesome, thanks!
PR Overview
This PR will address the following Issue/Feature: Issue #48
Applying the changes from @asmundu's PR https://github.com/fivetran/dbt_google_ads/pull/36 to most recent version of our google ads package.
This PR will result in the following new package version:
v0.9.2
This is adding a new field and does not affect downstream models, therefore will not be a breaking change.
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
This PR adds the
currency_code
field to the following models: google_ads__ad_group_report.sql google_ads__ad_report.sql google_ads__campaign_report.sql google_ads__keyword_report.sql google_ads__url_report.sqlPR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
After running the models I now see![image](https://github.com/fivetran/dbt_google_ads/assets/91097070/c17c5276-aea2-493d-822b-3af311357fb6)
currency_code
as an added field. Example compiled code below:Outputted models in target warehouse now have the additional field:![image](https://github.com/fivetran/dbt_google_ads/assets/91097070/c2e3b8e9-8dba-4c17-a78b-a715a7006b2d)
Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
🤑