fivetran / dbt_google_ads

Fivetran data transformations for Google Ads built using dbt.
https://fivetran.github.io/dbt_google_ads/
Apache License 2.0
13 stars 29 forks source link

add currency field #49

Closed fivetran-reneeli closed 1 year ago

fivetran-reneeli commented 1 year ago

PR Overview

This PR will address the following Issue/Feature: Issue #48

Applying the changes from @asmundu's PR https://github.com/fivetran/dbt_google_ads/pull/36 to most recent version of our google ads package.

This PR will result in the following new package version: v0.9.2

This is adding a new field and does not affect downstream models, therefore will not be a breaking change.

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:

This PR adds the currency_code field to the following models: google_ads__ad_group_report.sql google_ads__ad_report.sql google_ads__campaign_report.sql google_ads__keyword_report.sql google_ads__url_report.sql

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

Before marking this PR as "ready for review" the following have been applied:

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

After running the models I now see currency_code as an added field. Example compiled code below: image

Outputted models in target warehouse now have the additional field: image

Standard Updates

Please acknowledge that your PR contains the following standard updates:

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

If you had to summarize this PR in an emoji, which would it be?

🤑
fivetran-joemarkiewicz commented 1 year ago

Looks like BuildKite is passing!

fivetran-reneeli commented 1 year ago

awesome, thanks!