This PR will address the following Issue/Feature: #53
This PR will result in the following new package version:
9.3
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
Updated end models to select key columns from the stats source instead of the reports source to avoid introducing null values.
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
[ ] ~dbt compile~
[ ] ~dbt run –full-refresh~
[x] dbt run
[x] dbt test
[ ] ~dbt run –vars (if applicable)~
Before marking this PR as "ready for review" the following have been applied:
[x] The appropriate issue has been linked and tagged
[x] You are assigned to the corresponding issue and this PR
[x] BuildKite integration tests are passing
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
[x] You have validated these changes and assure this PR will address the respective Issue/Feature.
[x] You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
[x] You have provided details below around the validation steps performed to gain confidence in these changes.
Test error resolved--see before and after screencaps below. I was able to reproduce the error in our data, albeit for a different model than the customer experienced. As a result, I updated all affected models (that weren't already updated.) Also note the warning is a separate issue that is not a part of this issue. The important message is 0 errors in the updated results!
Before:
After:
Standard Updates
Please acknowledge that your PR contains the following standard updates:
Package versioning has been appropriately indexed in the following locations:
[x] indexed within dbt_project.yml
[x] indexed within integration_tests/dbt_project.yml
[x] CHANGELOG has individual entries for each respective change in this PR
[ ] ~README updates have been applied (if applicable)~
[ ] ~DECISIONLOG updates have been updated (if applicable)~
[ ] ~Appropriate yml documentation has been added (if applicable)~
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
[x] docs were regenerated (unless this PR does not include any code or yml updates)
If you had to summarize this PR in an emoji, which would it be?
Thanks for the explanation @fivetran-jamie! I updated them to select from the left side. I double checked the tests and agree this should cover everything.
PR Overview
This PR will address the following Issue/Feature: #53
This PR will result in the following new package version:
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
Test error resolved--see before and after screencaps below. I was able to reproduce the error in our data, albeit for a different model than the customer experienced. As a result, I updated all affected models (that weren't already updated.) Also note the warning is a separate issue that is not a part of this issue. The important message is 0 errors in the updated results!
Before:![Screenshot 2023-08-30 at 1 47 53 PM](https://github.com/fivetran/dbt_google_ads/assets/111930712/3709f0cf-4523-4ade-bb9e-e6c2b3be1a6b)
After:![Screenshot 2023-08-30 at 1 48 07 PM](https://github.com/fivetran/dbt_google_ads/assets/111930712/339c44ce-8cfc-4da3-bc8b-8e8b98e93459)
Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
🐝