fivetran / dbt_google_ads

Fivetran data transformations for Google Ads built using dbt.
https://fivetran.github.io/dbt_google_ads/
Apache License 2.0
13 stars 29 forks source link

Bug/selected join table #57

Closed fivetran-catfritz closed 1 year ago

fivetran-catfritz commented 1 year ago

PR Overview

This PR will address the following Issue/Feature: #53

This PR will result in the following new package version:

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

Before marking this PR as "ready for review" the following have been applied:

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

Test error resolved--see before and after screencaps below. I was able to reproduce the error in our data, albeit for a different model than the customer experienced. As a result, I updated all affected models (that weren't already updated.) Also note the warning is a separate issue that is not a part of this issue. The important message is 0 errors in the updated results!

Standard Updates

Please acknowledge that your PR contains the following standard updates:

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

If you had to summarize this PR in an emoji, which would it be?

🐝
fivetran-catfritz commented 1 year ago

Thanks for the explanation @fivetran-jamie! I updated them to select from the left side. I double checked the tests and agree this should cover everything.