This PR will address the following Issue/Feature:
Reverse some changes made in PR https://github.com/fivetran/dbt_google_ads/issues/50, specifically the docs that mention dbt-expectations version was updated to [v0.9.0,v0.10.0]. This upstream update in google ads source cause version conflicts for customers using other packages also leveraging dbt-expectations. We will need to make a universal bump to that version rather than just in google ads source. So for now, we will reverse those docs
This PR will result in the following new package version:
Wrapping into next batch of releases
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
see above
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
[n/a] dbt compile
[n/a] dbt run –full-refresh
[n/a] dbt run
[n/a] dbt test
[ ] dbt run –vars (if applicable)
Before marking this PR as "ready for review" the following have been applied:
[n/a] The appropriate issue has been linked and tagged
[x] You are assigned to the corresponding issue and this PR
[x] BuildKite integration tests are passing
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
[x] You have validated these changes and assure this PR will address the respective Issue/Feature.
[x] You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
[x] You have provided details below around the validation steps performed to gain confidence in these changes.
This is merely changes to the docs, and won't affect the code
Standard Updates
Please acknowledge that your PR contains the following standard updates:
Package versioning has been appropriately indexed in the following locations:
[n/a] indexed within dbt_project.yml
[n/a] indexed within integration_tests/dbt_project.yml
[x] CHANGELOG has individual entries for each respective change in this PR
[x] README updates have been applied (if applicable)
[n/a] DECISIONLOG updates have been updated (if applicable)
[n/a] Appropriate yml documentation has been added (if applicable)
❗ Special Updates for Ad Reporting ❗
To reduce integration testing time, not all models should be enabled in the run_models.sh vars. Update the variables after dbt run and dbt test to set:
[x] this PR's package to true
[x] Google Ads and Facebook Ads to true (if not already)
[x] All other packages to falseS
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
[n/a] docs were regenerated (unless this PR does not include any code or yml updates)
If you had to summarize this PR in an emoji, which would it be?
PR Overview
This PR will address the following Issue/Feature: Reverse some changes made in PR https://github.com/fivetran/dbt_google_ads/issues/50, specifically the docs that mention dbt-expectations version was updated to [v0.9.0,v0.10.0]. This upstream update in google ads source cause version conflicts for customers using other packages also leveraging dbt-expectations. We will need to make a universal bump to that version rather than just in google ads source. So for now, we will reverse those docs
This PR will result in the following new package version:
Wrapping into next batch of releases
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
This is merely changes to the docs, and won't affect the code
Standard Updates
Please acknowledge that your PR contains the following standard updates:
❗ Special Updates for Ad Reporting ❗
To reduce integration testing time, not all models should be enabled in the
run_models.sh
vars. Update the variables afterdbt run
anddbt test
to set:true
true
(if not already)false
Sdbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
:dancer: