Open fivetran-catfritz opened 9 months ago
The latest release of this package has been updated to use the custom google_ads_source.extract_url_parameter()
macro. This addresses the immediate issue raised in this feature request. However, in the next breaking change of this package we will want to remove the custom macro and swap the package to leverage the fivetran_utils.extract_url_parameter()
macro.
This was not implemented originally as it could possibly have caused breaking changes, we wanted to address the issue in a timely manner while ensuring we did not break any transformation pipelines.
Copied from fivetran/dbt_facebook_ads #37.
Is there an existing feature request for this?
Describe the Feature
An issue with
dbt_utils.get_url_parameter
was discovered in https://github.com/fivetran/dbt_linkedin_source/issues/55 for Databricks SQL. Macrofivetran_utils.extract_url_parameter
was added to solve this issue for Databricks targets (see https://github.com/fivetran/dbt_fivetran_utils/pull/130 more info).For this package, references to
dbt_utils.get_url_parameter
need to be updated tofivetran_utils.extract_url_parameter
.