fivetran / dbt_google_ads_source

Fivetran data models for Google Ads built using dbt.
https://fivetran.github.io/dbt_google_ads_source/
Apache License 2.0
10 stars 20 forks source link

[Bug] dbt_expectations <0.9.0 dependency #44

Closed raphaelvarieras closed 12 months ago

raphaelvarieras commented 1 year ago

Is there an existing issue for this?

Describe the issue

The latest version out of dbt-expectations is 0.9.0 and this package forces us to pin to an older version.

Relevant error log or model output

N/A

Expected behavior

Update the package to support 0.9.0

dbt Project configurations

N/A

Package versions

N/A

What database are you using dbt with?

snowflake

dbt Version

1.6

Additional Context

No response

Are you willing to open a PR to help address this issue?

fivetran-jamie commented 1 year ago

Hi there @raphaelvarieras, thanks for opening this issue!

I just tested the Google Ads packages out locally with v0.9.0 of dbt-expectations, and everything seems to work smoothly! Don't think we'll need to update anything other than the packages.yml.

The team and I will get slot this in for our next sprint and just validate that there aren't any unintended consequences in our downstream Ad Reporting models

fivetran-reneeli commented 1 year ago

Thanks @raphaelvarieras for raising this! This has been included in our most recent release.

fivetran-reneeli commented 1 year ago

Never mind, taking that back. We didn't realize this was cause errors for those using our other packages that are also on the older version of dbt expectations. So we will be rolling this out universally instead. But in the meantime we will roll back this change

jstingey commented 1 year ago

@fivetran-reneeli imports of fivetran/ad_reporting is still failing dbt deps with the incompatible versions for dbt_expectations.

fivetran-joemarkiewicz commented 1 year ago

Hi @jstingey can you confirm if this failure is still occurring?

fivetran-joemarkiewicz commented 1 year ago

For all following this thread - Our team will be working on making this update in our current sprint and will be making this a breaking change for the google (and downstream) packages so we may avoid dependency errors that were previously encountered by users.

We apologize for the failures that were caused as a result of the previous release and appreciate all of you working with us to correct the issue and forge a path forward for a better result to come with no unforeseen dependency errors.

fivetran-reneeli commented 1 year ago

Hi all, thanks for your patience! The updates will be provided in our next release in the following week.

fivetran-catfritz commented 12 months ago

This feature has been added to v0.10.0 and released today! Closing out this issue, but please continue to let us know any feedback!