fivetran / dbt_greenhouse_source

Data source models for Fivetran's Greenhouse connector built using dbt.
https://fivetran.github.io/dbt_greenhouse_source/
Apache License 2.0
2 stars 6 forks source link

[Feature] Update collect_freshness config in src_greenhouse.yml to account for dbt macro logic #27

Closed fivetran-avinash closed 1 week ago

fivetran-avinash commented 1 year ago

Is there an existing feature request for this?

Describe the Feature

Our fivetran_utils collect_freshness macro was designed to override dbt's equivalent macro to allow for the enabling/disabling of variables when running dbt source snapshot-freshness. Thus if a source table does not exist, dbt will not run (and error on) a freshness test on the table.

dbt has since updated its macro in recent versions to basically provide the same functionality. So warnings are being thrown to upgrade the package logic.

We will want to modify all versions of the meta: is_enabled config in our src_greenhouse.yml package (example here) to match the config: enabled dbt logic. Once those dependencies are either updated or removed, we can further explore updates to our own internal collect_freshness macro.

Describe alternatives you've considered

At the moment, we will be proceeding forward with updating dbt_fivetran_utils to match the logic of dbt's collect_freshness macro. That way customers will no longer experience that warning.

More details can be found in this ticket.

Are you interested in contributing this feature?

Anything else?

Customers raising this issue can be found in this dbt slack thread https://getdbt.slack.com/archives/C03SAHKKG2Z/p1683127164993329

fivetran-reneeli commented 1 week ago

this has been addressed in the mentioned release!