Feature/add typeid - Githubissues

fivetran-catfritz commented 1 year ago

PR Overview

This PR will address the following Issue/Feature: https://github.com/fivetran/dbt_hubspot_source/issues/106

This PR will result in the following new package version:

0.10.0 - Columns being added in the source and this package. Source was made a breaking change.

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:

Columns added to several tables in the source, but the only tables used in this package are DEAL_PIPELINE and DEAL_PIPELINE_STAGE. Added the corresponding new ...created_at and ...updated_at columns to these tables.
Also updated the docs with these definitions.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

[x] dbt compile
[x] dbt run –full-refresh
[x] dbt run
[x] dbt test
[x] dbt run –vars (see ticket for vars used)

Before marking this PR as "ready for review" the following have been applied:

[x] The appropriate issue has been linked and tagged
[x] You are assigned to the corresponding issue and this PR
[x] BuildKite integration tests are passing

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

[x] You have validated these changes and assure this PR will address the respective Issue/Feature.
[x] You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
[x] You have provided details below around the validation steps performed to gain confidence in these changes.
Validated using data provided in ticket. Ran the published package on our dataset, ran the updated package, and confirm the columns were added with no change in row count/grain.

Standard Updates

Please acknowledge that your PR contains the following standard updates:

Package versioning has been appropriately indexed in the following locations:
- [x] indexed within dbt_project.yml
- [x] indexed within integration_tests/dbt_project.yml
[x] CHANGELOG has individual entries for each respective change in this PR
[x] README updates have been applied (if applicable)
[ ] ~DECISIONLOG updates have been updated (if applicable)~
[x] Appropriate yml documentation has been added (if applicable)

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

[x] docs were regenerated (unless this PR does not include any code or yml updates)

If you had to summarize this PR in an emoji, which would it be?

🐑

fivetran-jamie commented 1 year ago

FYI i changed the base branch! i made releases/v.10.latest yesterday and merged the customer's PR into that one (it was originally v0.9.latest as i didn't see that your changes were breaking). so if you could resolve the merge conflicts around the versioning that would be great! i'm also happy to do it if it's confusing at all, i just didn't wanna go rogue and edit your branch 😄