Closed fivetran-catfritz closed 1 year ago
FYI i changed the base branch! i made releases/v.10.latest
yesterday and merged the customer's PR into that one (it was originally v0.9.latest as i didn't see that your changes were breaking). so if you could resolve the merge conflicts around the versioning that would be great! i'm also happy to do it if it's confusing at all, i just didn't wanna go rogue and edit your branch 😄
Thanks @fivetran-jamie! Sorry I missed that you already had the release branch. I got the conflicts resolved!
PR Overview
This PR will address the following Issue/Feature: https://github.com/fivetran/dbt_hubspot_source/issues/106
This PR will result in the following new package version:
0.10.0 - Columns being added in the source and this package. Source was made a breaking change.
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
DEAL_PIPELINE
andDEAL_PIPELINE_STAGE
. Added the corresponding new...created_at
and...updated_at
columns to these tables.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
🐑