fivetran / dbt_hubspot

Data models for Hubspot built using dbt.
https://fivetran.github.io/dbt_hubspot/
Apache License 2.0
33 stars 38 forks source link

explicit casts #113

Closed fivetran-reneeli closed 1 year ago

fivetran-reneeli commented 1 year ago

PR Overview

This PR will address the following Issue/Feature: https://github.com/fivetran/dbt_hubspot_source/issues/107

This PR will result in the following new package version: 0.10.1

This is non breaking because it will not affect output for existing customers

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:

Explicitly casts join fields in hubspot__deals as the appropriate data types to avoid potential errors in joining. (engagement_id and deal_id)

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

Before marking this PR as "ready for review" the following have been applied:

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

The hubspot__deals model runs successfully.

Standard Updates

Please acknowledge that your PR contains the following standard updates:

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

If you had to summarize this PR in an emoji, which would it be?

:dancer:
fivetran-reneeli commented 1 year ago

currently unable to generate new docs