Closed fivetran-joemarkiewicz closed 10 months ago
@fivetran-jamie thanks for reviewing! I made some updates to my branch to account for your review notes and also included some new variables (also introduced in my source PR changes) that allow users to disable the history models if they wish. Would you be able to give another glance to make sure all looks good following my updates?
PR Overview
This PR will address the following Issue/Feature: dbt_hubspot_source #117
This PR will result in the following new package version:
v0.14.0
Since this is changing the name of a field in the end model this will be breaking.
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
🚨 Breaking Changes 🚨
created_at
field in thehubspot__contacts
model has been renamed tocreated_date
to be consistent with the source data and avoid duplicate columns when persisting allproperty_*
fields at the source package.Under the Hood
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
I was able to confirm that the field changes in the end model. Please see the source package for further validation checks.
Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
📆