This PR will address the following Issue/Feature:
Quarterly project to add service/ticket models
This PR will result in the following new package version:
breaking: v0.14.0
non-breaking: v0.13.1
for users who have not explicitly set hubspot__service_enabled to true, nothing will change (besides the tiny source package patch i added)
for users who have hubspot__service_enabled set to true, a lot will change!! they'll have two new end models, one of which is a pretty hefty incremental model with incremental intermediate models. that's probably something a user should explicitly elect to have so...breaking?
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
[x] dbt compile
[x] dbt run –full-refresh
[x] dbt run
[x] dbt test
[x] dbt run –vars (if applicable)
Before marking this PR as "ready for review" the following have been applied:
[ ] The appropriate issue has been linked and tagged
[ ] You are assigned to the corresponding issue and this PR
[x] BuildKite integration tests are passing
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
[x] You have validated these changes and assure this PR will address the respective Issue/Feature.
[x] You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
[x] You have provided details below around the validation steps performed to gain confidence in these changes.
for ticket history
looked at our available dataset and compared ticket changes in the source ticket_property_history table to the end model.
for ticket enhanced model
this one was fairly straightforward, as my code is basically just dynamic joins and a call to the pre-existing engagements_aggregated macro
for more details see slack DM
Standard Updates
Please acknowledge that your PR contains the following standard updates:
Package versioning has been appropriately indexed in the following locations:
[x] indexed within dbt_project.yml
[x] indexed within integration_tests/dbt_project.yml
[x] CHANGELOG has individual entries for each respective change in this PR
[x] README updates have been applied (if applicable)
[ ] DECISIONLOG updates have been updated (if applicable)
[x] Appropriate yml documentation has been added (if applicable)
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
[x] docs were regenerated (unless this PR does not include any code or yml updates)
If you had to summarize this PR in an emoji, which would it be?
PR Overview
This PR will address the following Issue/Feature: Quarterly project to add service/ticket models
This PR will result in the following new package version:
breaking: v0.14.0 non-breaking: v0.13.1
for users who have not explicitly set
hubspot__service_enabledto true, nothing will change (besides the tiny source package patch i added)for users who have
hubspot__service_enabledset to true, a lot will change!! they'll have two new end models, one of which is a pretty hefty incremental model with incremental intermediate models. that's probably something a user should explicitly elect to have so...breaking?Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
for ticket history looked at our available dataset and compared ticket changes in the source
ticket_property_historytable to the end model.for ticket enhanced model this one was fairly straightforward, as my code is basically just dynamic joins and a call to the pre-existing
engagements_aggregatedmacrofor more details see slack DM
Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
🎃