Merged deals

[fivetran-reneeli]

PR Overview

This PR will address the following Issue/Feature: https://github.com/fivetran/dbt_hubspot/issues/134

This PR will result in the following new package version: 0.16.0

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:

We are adding logic to merge stale deals into the correct active deals based on the merged_deal table. This consists of 1. removing stale deals from the final deal models and 2. addition of a new field that lists all the merged deals per each active deal.

In addition we are adding back unique tests that we previously removed in #118 , using the dbt unique test config

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

• [x] dbt compile
• [ ] dbt run –full-refresh
• [x] dbt run
• [x] dbt test
• [x] dbt run –vars (if applicable) -- see height ticket for variables used

Before marking this PR as "ready for review" the following have been applied:

• [x] The appropriate issue has been linked and tagged
• [x] You are assigned to the corresponding issue and this PR
• [x] BuildKite integration tests are passing

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

• [x] You have validated these changes and assure this PR will address the respective Issue/Feature.
• [x] You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
• [x] You have provided details below around the validation steps performed to gain confidence in these changes.

  see linked hex journal

Standard Updates

Please acknowledge that your PR contains the following standard updates:

• Package versioning has been appropriately indexed in the following locations:
  • [x] indexed within dbt_project.yml
  • [x] indexed within integration_tests/dbt_project.yml
• [x] CHANGELOG has individual entries for each respective change in this PR
• [x] README updates have been applied (if applicable)
• [ ] DECISIONLOG updates have been updated (if applicable)
• [x] Appropriate yml documentation has been added (if applicable)

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

• [ ] docs were regenerated (unless this PR does not include any code or yml updates)

If you had to summarize this PR in an emoji, which would it be?

:dancer:

[fivetran-reneeli]

1. should we add the same unique test logic here since there is a is_ticket_deleted field

2. see my other comments

[fivetran-reneeli]

• [ ] docs

[fivetran-joemarkiewicz]

@fivetran-reneeli additionally I am now seeing a large number of test failures when running dbt test. Do you see these on your end as well?

[fivetran-reneeli]

Hi @fivetran-joemarkiewicz , I tried dbt test again and now I'm seeing the tests all pass, and compiling as expected...