search

fivetran / dbt_hubspot

Data models for Hubspot built using dbt.
https://fivetran.github.io/dbt_hubspot/
Apache License 2.0
33 stars 39 forks source link

feature/quickstart-yml-add #136

Closed fivetran-joemarkiewicz closed 8 months ago

fivetran-joemarkiewicz commented 8 months ago

PR to incorporate the quickstart.yml into the next release.

Additionally, I added extra config logic to handle a bug highlighted here. I was able to test and confirmed that this should address the bug initially raised by some quickstart users.

fivetran-joemarkiewicz commented 8 months ago

@fivetran-reneeli this PR is meant to include the quickstart.yml into the upcoming release. I have configured this to merge into your latest PR. Would you be able to review and merge in if all looks good.

fivetran-reneeli commented 8 months ago

merging in! I looked at why buildkite is failing and it's because of the updates I pushed in the source of correcting the default config for merged_deals to be false, but not here. should pass once i merge into my updated branch.

other thing is adding hubspot_merged_deal_enabled to the quickstart yml as well