This PR will address the following Issue/Feature: Internally raised issue
This PR will result in the following new package version:v0.17.0
I went back and forth on this one. However, I feel a breaking change is the best path forward here. There is the chance that the sudden introduction of these new variable configs could cause users who have working projects to all of a sudden see missing data. Therefore, I felt it would be best to categorize this as a breaking change to be safe.
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
🚨 Breaking Changes: Variable Bug Fixes 🚨
The following adjustments have been made concerning the hubspot_email_event_sent_enabled variable:
The hubspot__contact_lists email metric fields are now dependent on the hubspot_email_event_sent_enabled variable being defined as true.
The hubspot__contact email metric fields are now dependent on the hubspot_email_event_sent_enabled variable being defined as true.
The hubspot__email_campaigns model is now dependent on the hubspot_email_event_sent_enabled variable being defined as true.
The int_hubspot__email_metrics__by_contact_list model is now dependent on the hubspot_email_event_sent_enabled variable being defined as true.
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
[x] dbt run –full-refresh && dbt test
[x] dbt run (if incremental models are present) && dbt test
Before marking this PR as "ready for review" the following have been applied:
[x] The appropriate issue has been linked, tagged, and properly assigned
[x] All necessary documentation and version upgrades have been applied
[x] docs were regenerated (unless this PR does not include any code or yml updates)
[x] BuildKite integration tests are passing
[x] Detailed validation steps have been provided below
Detailed Validation
Please share any and all of your validation steps:
See below for the compilation validation steps:
When running on the latest version of the HubSpot package with the hubspot_email_event_enabled defined as true and the hubspot_email_event_sent_enabled variable defined as false I see the following error:
Then when testing this on the Dev version from this PR I see compilation success and also a successful run of the models
If you had to summarize this PR in an emoji, which would it be?
PR Overview
This PR will address the following Issue/Feature: Internally raised issue
This PR will result in the following new package version:
v0.17.0I went back and forth on this one. However, I feel a breaking change is the best path forward here. There is the chance that the sudden introduction of these new variable configs could cause users who have working projects to all of a sudden see missing data. Therefore, I felt it would be best to categorize this as a breaking change to be safe.
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
🚨 Breaking Changes: Variable Bug Fixes 🚨
hubspot_email_event_sent_enabledvariable:hubspot__contact_listsemail metric fields are now dependent on thehubspot_email_event_sent_enabledvariable being defined astrue.hubspot__contactemail metric fields are now dependent on thehubspot_email_event_sent_enabledvariable being defined astrue.hubspot__email_campaignsmodel is now dependent on thehubspot_email_event_sent_enabledvariable being defined astrue.int_hubspot__email_metrics__by_contact_listmodel is now dependent on thehubspot_email_event_sent_enabledvariable being defined astrue.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
See below for the compilation validation steps:
hubspot_email_event_enableddefined astrueand thehubspot_email_event_sent_enabledvariable defined asfalseI see the following error:If you had to summarize this PR in an emoji, which would it be?
📧