This PR will address the following Issue/Feature: [#141]
This PR will result in the following new package version: 0.17.2
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
🪲 Bug Fixes 🪛
Fixed the fivetran_utils.enabled_vars conditional by adding the hubspot_contact_list_member_enabled variable in hubspot_contact_lists to solve for compilation errors when the contact_list source table is not being used. If hubspot_contact_list_member_enabled is true, int_hubspot__email_metrics__by_contact_list is now brought in as a dependency, and ignored otherwise.
🚘 Under the Hood 🚘
Updated the integration_tests/dbt_project.yml variables to be global to ensure more effective testing of our seed data.
Updated the maintainer PR template to resemble the most up to date format.
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
[x] dbt run –full-refresh && dbt test
[NA] dbt run (if incremental models are present) && dbt test
Before marking this PR as "ready for review" the following have been applied:
[x] The appropriate issue has been linked, tagged, and properly assigned
[x] All necessary documentation and version upgrades have been applied
[x] docs were regenerated (unless this PR does not include any code or yml updates)
[x] BuildKite integration tests are passing
[x] Detailed validation steps have been provided below
Detailed Validation
Please share any and all of your validation steps:
Was able to reproduce the compilation error when I set hubspot_contact_list_member_enabled was set to false in integration_tests, and then confirm that adding the new variable config in hubspot_contact_lists fixed the issue.
If you had to summarize this PR in an emoji, which would it be?
PR Overview
This PR will address the following Issue/Feature: [#141]
This PR will result in the following new package version: 0.17.2
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
🪲 Bug Fixes 🪛
fivetran_utils.enabled_varsconditional by adding thehubspot_contact_list_member_enabledvariable inhubspot_contact_liststo solve for compilation errors when thecontact_listsource table is not being used. Ifhubspot_contact_list_member_enabledistrue,int_hubspot__email_metrics__by_contact_listis now brought in as a dependency, and ignored otherwise.🚘 Under the Hood 🚘
integration_tests/dbt_project.ymlvariables to be global to ensure more effective testing of our seed data.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
Was able to reproduce the compilation error when I set
hubspot_contact_list_member_enabledwas set to false inintegration_tests, and then confirm that adding the new variable config inhubspot_contact_listsfixed the issue.If you had to summarize this PR in an emoji, which would it be?
🥼