fivetran / dbt_hubspot

Data models for Hubspot built using dbt.
https://fivetran.github.io/dbt_hubspot/
Apache License 2.0
33 stars 39 forks source link

Fix typo in readme.md by removing extra s in configuration part for disabling models #74

Closed moreaupascal56 closed 2 years ago

moreaupascal56 commented 2 years ago

Pull Request Are you a current Fivetran customer? yes Pascal Moreau Yousign What change(s) does this PR introduce? fix typos in the readme, indeed in the disabling model section some onfig have extra s which are not part of the real config names. It is misleading.

Did you update the CHANGELOG?

Does this PR introduce a breaking change?

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

Is this PR in response to a previously created Bug or Feature Request

How did you test the PR changes?

Select which warehouse(s) were used to test the PR

Provide an emoji that best describes your current mood

:dancer: **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.
moreaupascal56 commented 2 years ago

same PR in the dbt_hubspot_source package https://github.com/fivetran/dbt_hubspot_source/pull/73

moreaupascal56 commented 2 years ago

@moreaupascal56 thank you so much for opening this PR to address the spelling errors of the variable names within the README. This is a change we want to push sooner than later to ensure other users are able to leverage the proper variable names when leveraging this package.

I made a few minor adjustments (updating the version of the package and adding a bit more to the CHANGELOG). Other than that, this PR looks good to go! I will merge and include in our next release (we practice release freezes on Friday, so you can expect this to go live Monday morning). We greatly appreciate your contribution to our packages. They are made better from the community members like yourself 😄

thanks for the nice words @fivetran-joemarkiewicz ! have a great day :)