Closed MarcelloMolinaro closed 1 year ago
Hi @MarcelloMolinaro thanks for raising this README error! This is definitely something we will want to address within our documentation so users are able to have a smoother experience.
I noticed you would be open to creating a PR to address this issue. If you would like to contribute, you can follow these steps or simply fork the package, make the readme change, and open the PR to address this issue.
I will then be happy to review your PR and work to integrate it into the next release of the package 😄
@fivetran-joemarkiewicz - I got some help on the world's tiniest PR. I hope I didn't break anything! Thanks for your help!
Is there an existing issue for this?
Describe the issue
The
hubspot_engagement_call_enabled
variable is misspelled ashubspot_engagement_calls_enabled
in the README in this section: hubspot_engagement_call_enabledRemoving the "s" fixed this issue since that is how it is spelled in the
hubpost__engagement_calls.sql
model:Relevant error log or model output
No response
Expected behavior
Since we do not use the
engagement_call
table I would expect that settinghubspot_engagement_calls_enabled: false
would result in all associated models not being created.dbt Project configurations
hubspot_engagement_call_enabled: false
workshubspot_engagement_calls_enabled: false
does nothingPackage versions
What database are you using dbt with?
snowflake
dbt Version
Core:
latest: 1.3.0 - Update available!
Your version of dbt-core is out of date! You can find instructions for upgrading here: https://docs.getdbt.com/docs/installation
Plugins:
Additional Context
No response
Are you willing to open a PR to help address this issue?