fivetran / dbt_hubspot

Data models for Hubspot built using dbt.
https://fivetran.github.io/dbt_hubspot/
Apache License 2.0
33 stars 39 forks source link

`hubspot_engagement_call_enabled` variable misspelled on README #85

Closed MarcelloMolinaro closed 1 year ago

MarcelloMolinaro commented 2 years ago

Is there an existing issue for this?

Describe the issue

The hubspot_engagement_call_enabled variable is misspelled as hubspot_engagement_calls_enabled in the README in this section: hubspot_engagement_call_enabled

Removing the "s" fixed this issue since that is how it is spelled in the hubpost__engagement_calls.sql model:

{{ config(enabled=fivetran_utils.enabled_vars(['hubspot_sales_enabled','hubspot_engagement_call_enabled','hubspot_engagement_enabled'])) }}

{{ engagements_joined(var('engagement_call')) }}

Relevant error log or model output

No response

Expected behavior

Since we do not use the engagement_call table I would expect that setting hubspot_engagement_calls_enabled: false would result in all associated models not being created.

dbt Project configurations

hubspot_engagement_call_enabled: false works hubspot_engagement_calls_enabled: false does nothing

Package versions

What database are you using dbt with?

snowflake

dbt Version

Core:

Plugins:

Additional Context

No response

Are you willing to open a PR to help address this issue?

fivetran-joemarkiewicz commented 2 years ago

Hi @MarcelloMolinaro thanks for raising this README error! This is definitely something we will want to address within our documentation so users are able to have a smoother experience.

I noticed you would be open to creating a PR to address this issue. If you would like to contribute, you can follow these steps or simply fork the package, make the readme change, and open the PR to address this issue.

I will then be happy to review your PR and work to integrate it into the next release of the package 😄

MarcelloMolinaro commented 2 years ago

@fivetran-joemarkiewicz - I got some help on the world's tiniest PR. I hope I didn't break anything! Thanks for your help!