fivetran / dbt_hubspot

Data models for Hubspot built using dbt.
https://fivetran.github.io/dbt_hubspot/
Apache License 2.0
33 stars 38 forks source link

[Bug] The hubspot__contacts calls upon the contact_merge_audits even though the table has been deprecated from the connector #97

Closed elanfivetran closed 1 year ago

elanfivetran commented 1 year ago

Is there an existing issue for this?

Describe the issue

Per the HubSpot Release Notes, Fivetran deprecated the CONTACT_MERGE_AUDIT table.

However, in the hubspot__contacts.sql model that exists in this package the CONTACT_MERGE_AUDIT table is still being referenced if hubspot_contact_merge_audit_enabled is marked as True in dbt_project.yml. Since most users moving forward will not have the CONTACT_MERGE_AUDIT in their schema, hubspot_contact_merge_audit_enabled should have a default of False.

Relevant error log or model output

No response

Expected behavior

Since most users moving forward will not have the CONTACT_MERGE_AUDIT in their schema, hubspot_contact_merge_audit_enabled should have a default of False.

dbt Project configurations

They are configured to the default settings.

Package versions

n/a

What database are you using dbt with?

bigquery

dbt Version

n/a

Additional Context

No response

Are you willing to open a PR to help address this issue?

fivetran-reneeli commented 1 year ago

Following office hours with customer running into duplicates resulting from the same issue, tagging @uxdi-rajan here

fivetran-jamie commented 1 year ago

the fix for this should officially be in v0.9.0 of the package!

uxdi-rajan commented 1 year ago

Thank you guys for working on this. Appreciate it!