This PR will result in the following new package version:
v0.10.0 - Adding columns to some tables that affect transform models.
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
Because of the May 2023 connector updatetype_id was added to DEAL_COMPANY and DEAL_CONTACT. These tables are not pulled into the transform package.
I also added column-combo tests for these tables since the update states these are meant to form a composite primary key.
Also resulting from the connector update, columns updated_at and created_at have been added to the following sources and their corresponding staging models:
DEAL_PIPELINE
DEAL_PIPELINE_STAGE
TICKET_PIPELINE
TICKET_PIPELINE_STAGE
These columns do get pulled into the transform package, for which I opened a PR on the transform.
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
[x] dbt compile
[x] dbt run –full-refresh
[x] dbt run
[x] dbt test
[x] dbt run –vars (see ticket for vars used)
Before marking this PR as "ready for review" the following have been applied:
[x] The appropriate issue has been linked and tagged
[x] You are assigned to the corresponding issue and this PR
[x] BuildKite integration tests are passing
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
[x] You have validated these changes and assure this PR will address the respective Issue/Feature.
[x] You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
They will affect transform, which I have opened a PR for in the transform.
[x] You have provided details below around the validation steps performed to gain confidence in these changes.
Validated using data provided in ticket and added tests mentioned above. This was a straight add of columns added by the connector. Ran the published package on our dataset, ran the updated package, and confirm the columns were added with no change in row count/grain.
Standard Updates
Please acknowledge that your PR contains the following standard updates:
Package versioning has been appropriately indexed in the following locations:
[x] indexed within dbt_project.yml
[x] indexed within integration_tests/dbt_project.yml
[x] CHANGELOG has individual entries for each respective change in this PR
[x] README updates have been applied (if applicable)
[ ] ~DECISIONLOG updates have been updated (if applicable)~
[x] Appropriate yml documentation has been added (if applicable)
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
[x] docs were regenerated (unless this PR does not include any code or yml updates)
If you had to summarize this PR in an emoji, which would it be?
PR Overview
This PR will address the following Issue/Feature:
106
This PR will result in the following new package version:
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
Because of the May 2023 connector update
type_id
was added toDEAL_COMPANY
andDEAL_CONTACT
. These tables are not pulled into the transform package.Also resulting from the connector update, columns
updated_at
andcreated_at
have been added to the following sources and their corresponding staging models:DEAL_PIPELINE
DEAL_PIPELINE_STAGE
TICKET_PIPELINE
TICKET_PIPELINE_STAGE
These columns do get pulled into the transform package, for which I opened a PR on the transform.
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
[x] You have validated these changes and assure this PR will address the respective Issue/Feature.
[x] You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
[x] You have provided details below around the validation steps performed to gain confidence in these changes.
Validated using data provided in ticket and added tests mentioned above. This was a straight add of columns added by the connector. Ran the published package on our dataset, ran the updated package, and confirm the columns were added with no change in row count/grain.
Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
🐈