Please provide your name and company
Pascal Moreau
Link the issue/feature request which this PR is meant to address
117
But overalls avoid duplicate issues with PROPERTY that would have the same name as the columns aliases in the get_contact_columns macro
Detail what changes this PR introduces and how this addresses the issue/feature request linked above.
This is a quick draft about how this could be fixed but that is just a suggestion, not sure that this is the best way
How did you validate the changes introduced within this PR?
just ran in local but needs to do more tests if you think this is a good way to do it
Which warehouse did you use to develop these changes?
Did you update the CHANGELOG?
[ ] Yes
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
[ ] Yes
Provide an emoji that best describes your current mood
🌞
**Feedback**
I think the release note for the version 0.9.0 is not very clear because to me this version and PR #100 should be in the breaking changes section as the columns are changing names (ie. createdate --> created_at).
**PR Template**
- [Community Pull Request Template](?expand=1&template=pull_request_template.md) (default)
- [Maintainer Pull Request Template](?expand=1&template=maintainer_pull_request_template.md) (to be used by maintainers)
Please provide your name and company Pascal Moreau
Link the issue/feature request which this PR is meant to address
117
But overalls avoid duplicate issues with PROPERTY that would have the same name as the columns aliases in the get_contact_columns macro
Detail what changes this PR introduces and how this addresses the issue/feature request linked above. This is a quick draft about how this could be fixed but that is just a suggestion, not sure that this is the best way
How did you validate the changes introduced within this PR? just ran in local but needs to do more tests if you think this is a good way to do it
Which warehouse did you use to develop these changes?
Did you update the CHANGELOG?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Provide an emoji that best describes your current mood
🌞 **Feedback** I think the release note for the version 0.9.0 is not very clear because to me this version and PR #100 should be in the breaking changes section as the columns are changing names (ie. createdate --> created_at). **PR Template** - [Community Pull Request Template](?expand=1&template=pull_request_template.md) (default) - [Maintainer Pull Request Template](?expand=1&template=maintainer_pull_request_template.md) (to be used by maintainers)