fivetran / dbt_hubspot_source

Data models for Hubspot built using dbt.
https://fivetran.github.io/dbt_hubspot_source/
Apache License 2.0
31 stars 30 forks source link

ensure v3 endpoint has appropriate `_deleted` field #120

Closed fivetran-jamie closed 10 months ago

fivetran-jamie commented 10 months ago

PR Overview

This PR will address the following Issue/Feature:

no issue made, i just noticed that the Service ERD has ticket.is_deleted in v2 of the endpoint and ticket._fivetran_deleted in v3 https://docs.google.com/presentation/d/1OIPFpkqkSYAPPFfq1-yICdfArg6mmG71P-cm15cpy7U/edit#slide=id.ged1442628e_0_0 vs https://docs.google.com/presentation/d/12IRX0kbZM18vus2tr7MUp9MXSvGVn93QCnPnrgNIAhA/edit#slide=id.ged1442628e_0_0

This PR will result in the following new package version:

0.12.1

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

Before marking this PR as "ready for review" the following have been applied:

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

ran dbt test before and after making the change and everything still succeeds. moreover, there's no fanout in downstream ticket models

Standard Updates

Please acknowledge that your PR contains the following standard updates:

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

If you had to summarize this PR in an emoji, which would it be?

💆