Closed fivetran-jamie closed 10 months ago
This PR will address the following Issue/Feature:
no issue made, i just noticed that the Service ERD has ticket.is_deleted in v2 of the endpoint and ticket._fivetran_deleted in v3 https://docs.google.com/presentation/d/1OIPFpkqkSYAPPFfq1-yICdfArg6mmG71P-cm15cpy7U/edit#slide=id.ged1442628e_0_0 vs https://docs.google.com/presentation/d/12IRX0kbZM18vus2tr7MUp9MXSvGVn93QCnPnrgNIAhA/edit#slide=id.ged1442628e_0_0
ticket.is_deleted
ticket._fivetran_deleted
This PR will result in the following new package version:
0.12.1
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
_fivetran_deleted
is_deleted
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
ran dbt test before and after making the change and everything still succeeds. moreover, there's no fanout in downstream ticket models
dbt test
Please acknowledge that your PR contains the following standard updates:
Please acknowledge that after the above were all completed the below were applied to your branch:
PR Overview
This PR will address the following Issue/Feature:
no issue made, i just noticed that the Service ERD has
ticket.is_deleted
in v2 of the endpoint andticket._fivetran_deleted
in v3 https://docs.google.com/presentation/d/1OIPFpkqkSYAPPFfq1-yICdfArg6mmG71P-cm15cpy7U/edit#slide=id.ged1442628e_0_0 vs https://docs.google.com/presentation/d/12IRX0kbZM18vus2tr7MUp9MXSvGVn93QCnPnrgNIAhA/edit#slide=id.ged1442628e_0_0This PR will result in the following new package version:
0.12.1
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
_fivetran_deleted
in the staging model and coalesce it with the old fieldis_deleted
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
ran
dbt test
before and after making the change and everything still succeeds. moreover, there's no fanout in downstream ticket modelsStandard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
💆