fivetran / dbt_hubspot_source

Data models for Hubspot built using dbt.
https://fivetran.github.io/dbt_hubspot_source/
Apache License 2.0
31 stars 30 forks source link

Moved is_deleted exclusion after fill_staging_columns macro #67

Closed sambradbury closed 2 years ago

sambradbury commented 2 years ago

Pull Request Are you a current Fivetran customer?

Sam B. -- Data Analyst -- Unchained Capital

What change(s) does this PR introduce?

This PR is a companion to one created by @fivetran-joemarkiewicz to resolve possible build failures that may occur when syncing certain HubSpot tables that do not have any recorded deletion events. Fivetran lists the tables that they 'Capture deletes' for here: https://fivetran.com/docs/applications/hubspot and this PR resolves a problem that can occur in the modeling of tickets since hubspot does not explicitly support the is_deleted column.

Did you update the CHANGELOG?

Does this PR introduce a breaking change?

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

Is this PR in response to a previously created Bug or Feature Request

How did you test the PR changes?

Select which warehouse(s) were used to test the PR

Provide an emoji that best describes your current mood

:dancer: **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.