fivetran / dbt_hubspot_source

Data models for Hubspot built using dbt.
https://fivetran.github.io/dbt_hubspot_source/
Apache License 2.0
31 stars 30 forks source link

Parametrize husbpot_source name #74

Closed moreaupascal56 closed 2 years ago

moreaupascal56 commented 2 years ago

Pull Request Are you a current Fivetran customer?

Pascal Moreau yousign What change(s) does this PR introduce?

Give the possibility to parametrize the source name, in my case another source is called hubspot (from a former integration process) and this is unclear with the default hubspot name here. It was easier to parametrize it in this package than changing the legacy name we want to keep for now. It may be useful for others.

Did you update the CHANGELOG?

Does this PR introduce a breaking change?

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

Is this PR in response to a previously created Bug or Feature Request

How did you test the PR changes?

Select which warehouse(s) were used to test the PR

Provide an emoji that best describes your current mood

:dancer: **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.
moreaupascal56 commented 2 years ago

Hello ! I'd like to parametrize dbt freshness parameters as well but I'm planning to do it on another PR, I can do it here as well if you prefer.