Closed fivetran-seanodriscoll closed 1 year ago
@fivetran-seanodriscoll Thanks for opening the PR, and we really appreciate your contribution! I'll be reviewing this in the coming week and will let you know if I have questions or feedback.
@fivetran-catfritz No problem at all!
Pull Request Are you a current Fivetran customer?
Sean O'Driscoll, Fivetran SE (EMEA)
What change(s) does this PR introduce?
Fixes an apparent copy+paste error in
models/stg_hubspot__engagement_meeting.sql
.hubspot_engagement_meeting_enabled
var in thedbt_project.yml
hubspot_engagement_email_enabled
varDid you update the CHANGELOG?
Does this PR introduce a breaking change?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Output of
dbt run
whenhubspot_engagement_meeting_enabled: false
is included in dbt project vars. i.e. it's not excluding this model when it should be since the var reference inside the model is incorrect:Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
:dancer: **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.