[Bug] Engagement Meeting Staging Model Has Wrong Variables

fivetran-joemarkiewicz commented 2 years ago

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the issue

Currently, the stg_hubspot__engagement_meeting has an incorrect variable within the enable config https://github.com/fivetran/dbt_hubspot_source/blob/198a840aa11aaf48f50e092e2c9c7a5ef21e581a/models/stg_hubspot__engagement_meeting.sql#L1

Instead of the hubspot_engagement_email_enabled variable being included in the model, it should instead have hubspot_engagement_meeting_enabled.

This is because the hubspot_engagement_email_enabled variable should only apply to the email staging models. This model however should be configured to use the relevant variable that was created for the engagement meeting (hubspot_engagement_email_enabled).

Relevant error log or model output

See the error output in the additional details.

Expected behavior

The package uses the proper variables to disable this model.

dbt Project configurations

vars:
  hubspot_engagement_email_enabled: true
  hubspot_engagement_meeting_enabled: false

Package versions

packages:
  - package: fivetran/hubspot_source
    version: [">=0.6.0", "<0.7.0"]

What database are you using dbt with?

bigquery

dbt Version

dbt v1.2.0

Additional Context

Are you willing to open a PR to help address this issue?

[X] Yes.
[ ] Yes, but I will need assistance and will schedule time during our office hours for guidance
[ ] No.

fivetran-joemarkiewicz commented 2 years ago

FYI - We will want to assess the upstream and downstream models from stg_hubspot__engagement_meeting and ensure the variables are correct. If they are not, we will need to update those as well.

fivetran-catfritz commented 1 year ago

This bug has been addressed in the latest release 0.6.3. Check the release notes for more info. Closing this issue.

fivetran / dbt_hubspot_source