Closed jamesrayoub closed 1 year ago
Hey @jamesrayoub, thank you for your work on this PR! I have actually been working on a change for a different issue that I suspect may help you get what you need here. Would you like to take a look at and maybe test out this PR and see if it would help get you what you need?
Are you a current Fivetran customer? Yes, Dandelion Energy
What change(s) does this PR introduce? Restores deleted deal pipelines and deal pipeline stages to
stg_hubspot__deal_pipeline
andstg_hubspot__deal_pipeline_stage
, respectively. Repurposes theis_active
boolean column to return the inverse of_fivetran_deleted
given HubSpot hard deletes pipelines andis_active
is always true (in our instance at least). Did you update the CHANGELOG?Does this PR introduce a breaking change?
This should not cause any of the uniqueness or null tests to fail for either object unless users somehow delete and re-create pipelines or stages with the same enum/ID (I don't believe this is possible anymore)
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood 🕵️♂️
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.