search

fivetran / dbt_intercom_source

Data source models for Fivetran's Intercom connector built using dbt.
https://fivetran.github.io/dbt_intercom_source/
Apache License 2.0
3 stars 7 forks source link

BUG - Freshness tests fail when models disabled #13

Closed fivetran-joemarkiewicz closed 2 years ago

fivetran-joemarkiewicz commented 2 years ago

Are you a current Fivetran customer?

Fivetran created Issue

Describe the bug

When a users sets a model enabled variable to false (ie. intercom__using_company_tags: false), then the freshness tests will error out because the user does not in fact have that table in their source system.

Steps to reproduce

  1. Don't have one of the tables in your source.
  2. Set the variable to false to disable the use of it.
  3. Run dbt source freshness and watch an error occur because the freshness test on that source table is still being run.

Expected behavior

When a user disables a model, the freshness tests do not run.

Package Version

packages:
  - package: fivetran/intercom_source
    version: [">=0.3.0", "<0.4.0"]

Warehouse

- [X] BigQuery - [X] Redshift - [X] Snowflake - [X] Postgres - [ ] Databricks - [ ] Other (provide details below) **Additional context** This same issue has already been resolved in other dbt packages. See the [dbt_greenhouse_source](https://github.com/fivetran/dbt_greenhouse_source/pull/15/files) PR for how this is resolved.
fivetran-joemarkiewicz commented 2 years ago

This fix will be live in the next v1 release of the intercom_source package 🎉