search

fivetran / dbt_intercom_source

Data source models for Fivetran's Intercom connector built using dbt.
https://fivetran.github.io/dbt_intercom_source/
Apache License 2.0
3 stars 7 forks source link

bugfix/remove-unique-test-on-company_id #31

Closed matthew-LL closed 11 months ago

matthew-LL commented 11 months ago

Fix for this issue - https://github.com/fivetran/dbt_intercom_source/issues/30

This PR removes a uniqueness test that was causing errors as a result of the stg_intercom__company_history model not being unique on company_id since a new row is added per company whenever the intercom company history is updated.

fivetran-joemarkiewicz commented 11 months ago

Thanks for making the update in your PR @matthew-LL! This looks great to me. Other than this, there are a few minor updates we need to make to the branch before this will be good to merge into main and release. I can easily handle these minor updates (version bump, CHANGELOG entry, docs regeneration). Are you comfortable if I commit directly to your branch to apply these changes before approving and merging?

matthew-LL commented 11 months ago

I've been on annual leave for a couple days so apologies for my lack of response, thanks for closing this!