This PR will address the following Issue/Feature: [#111]
This PR will result in the following new package version:
Breaking as we are changing the incremental logic.
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
🚨 Breaking Changes 🚨
Refactored int_jira__issue_calendar_spine to reduce computational load and ensure proper incremental runs.
Created the int_jira__calendar_spine to move the calendar spine into its own model. That is then joined into the issue calendar spine.
Moved the issue_dates CTE join into int_jira__field_history_scd to avoid loading all the issue lines within the issue calendar spine on incremental loads.
Updated and added incremental logic in both int_jira__issue_calendar_spine and jira__daily_issue_field_history to filter and insert records based on the issues present in the respective models.
🚘 Under the Hood 🚘
Updated jira__daily_issue_field_history to exclude the created_on and open_until fields from the pivoted field operations in this model. These fields were created from the issue_dates CTE and are only needed for the int_jira__issue_calendar_spine.
📜 Documentation Updates 📜
Updated the README (see the Extend the history of an issue past its closing date section in Additional Configurations) with an explanation for what the jira_issue_history_buffer does in int_jira__issue_calendar_spine.
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
[x] dbt compile
[x] dbt run –full-refresh
[x] dbt run
[x] dbt test
[NA] dbt run –vars (if applicable)
Before marking this PR as "ready for review" the following have been applied:
[x] The appropriate issue has been linked and tagged
[x] You are assigned to the corresponding issue and this PR
[x] BuildKite integration tests are passing
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
[x] You have validated these changes and assure this PR will address the respective Issue/Feature.
[x] You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
[x] You have provided details below around the validation steps performed to gain confidence in these changes.
Applying these changes brought in the new fields in significantly reduced runtime on an incremental dbt run.
Standard Updates
Please acknowledge that your PR contains the following standard updates:
Package versioning has been appropriately indexed in the following locations:
[x] indexed within dbt_project.yml
[x] indexed within integration_tests/dbt_project.yml
[x] CHANGELOG has individual entries for each respective change in this PR
[x] README updates have been applied (if applicable)
[NA] DECISIONLOG updates have been updated (if applicable)
[NA] Appropriate yml documentation has been added (if applicable)
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
[x] docs were regenerated (unless this PR does not include any code or yml updates)
If you had to summarize this PR in an emoji, which would it be?
PR Overview
This PR will address the following Issue/Feature: [#111]
This PR will result in the following new package version:
Breaking as we are changing the incremental logic.
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
🚨 Breaking Changes 🚨
int_jira__issue_calendar_spineto reduce computational load and ensure proper incremental runs.int_jira__calendar_spineto move the calendar spine into its own model. That is then joined into the issue calendar spine.issue_datesCTE join intoint_jira__field_history_scdto avoid loading all the issue lines within the issue calendar spine on incremental loads.int_jira__issue_calendar_spineandjira__daily_issue_field_historyto filter and insert records based on the issues present in the respective models.🚘 Under the Hood 🚘
jira__daily_issue_field_historyto exclude thecreated_onandopen_untilfields from the pivoted field operations in this model. These fields were created from theissue_datesCTE and are only needed for theint_jira__issue_calendar_spine.📜 Documentation Updates 📜
Extend the history of an issue past its closing datesection in Additional Configurations) with an explanation for what thejira_issue_history_bufferdoes inint_jira__issue_calendar_spine.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
Applying these changes brought in the new fields in significantly reduced runtime on an incremental
dbt run.Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
📆