fivetran / dbt_jira

Data models for Fivetran's Jira connector built using dbt.
https://fivetran.github.io/dbt_jira/
Apache License 2.0
8 stars 15 forks source link

Partition by fix within field history models #37

Closed fivetran-joemarkiewicz closed 3 years ago

fivetran-joemarkiewicz commented 3 years ago

Are you a current Fivetran customer?

Fivetran created PR.

What change(s) does this PR introduce?

This PR introduces a refactor of our jira__daily_issue_field_history and int_jira__field_history_scd models by adjusting the sum and first value window functions to include appropriate partition by statements to capture the accurate jira field history changes.

This issue and solution was brought to our attention by @RivkiHofman. Thanks! 🎉

Does this PR introduce a breaking change?

This is a simple code refactor to fix an incorrect issue field history calculation. This change will have no breaking impact on existing users.

Is this PR in response to a previously created Issue

How did you test the PR changes?

- [X] CircleCi - [ ] Other (please provide additional testing details below) **Select which warehouse(s) were used to test the PR** - [X] BigQuery - [X] Redshift - [X] Snowflake - [X] Postgres - [ ] Databricks - [ ] Other (provide details below) **Provide an emoji that best describes your current mood** 🗄️ **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.