search

fivetran / dbt_jira

Data models for Fivetran's Jira connector built using dbt.
https://fivetran.github.io/dbt_jira/
Apache License 2.0
8 stars 15 forks source link

dbt utils snowflake conditional revert #40

Closed fivetran-joemarkiewicz closed 2 years ago

fivetran-joemarkiewicz commented 2 years ago

Are you a current Fivetran customer?

Fivetran created PR

What change(s) does this PR introduce?

With the patch release of dbt-utils v0.7.3 the snowflake uppercase fix no longer is needed and thus is removed from our int_jira__issue_users model.

Does this PR introduce a breaking change?

This simply removes a Snowflake conditional that is no longer needed and is actually breaking users runs currently.

Is this PR in response to a previously created Issue

How did you test the PR changes?

- [x] CircleCi - [ ] Other (please provide additional testing details below) **Select which warehouse(s) were used to test the PR** - [X] BigQuery - [X] Redshift - [X] Snowflake - [X] Postgres - [ ] Databricks - [ ] Other (provide details below) **Provide an emoji that best describes your current mood** 🧯 **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.
fivetran-joemarkiewicz commented 2 years ago

lgtm -- and oy we'll definitely have to change this in our other packages...

Thanks for catching this in the other packages! @fivetran-jamie would you be able to open a bug fix request in those other packages?