fivetran / dbt_jira

Data models for Fivetran's Jira connector built using dbt.
https://fivetran.github.io/dbt_jira/
Apache License 2.0
8 stars 15 forks source link

FEATURE - use dbt_utils.slugify() to use issue field names instead of IDs as column names #43

Closed fivetran-jamie closed 2 years ago

fivetran-jamie commented 2 years ago

Are you a Fivetran customer?

fivetran made issue

Is your feature request related to a problem? Please describe.

not a problem per se, but a suboptimal solution to a previous problem regarding [daily issue history fields](https://github.com/fivetran/dbt_jira#daily-issue-field-history-columns). we decided to use field_ids to avoid special characters in column names in this PR https://github.com/fivetran/dbt_jira/pull/25 having columns called `customfield_[id_number]` isn't very user friendly, and i imagine users are renaming these columns as their actual field_names on top of the package models **Describe the solution you'd like** it would be great to have the columns named as their respective `field.name` instead of their ID. we can use dbt_utils.slugify() for this i think https://github.com/dbt-labs/dbt-utils/blob/main/macros/jinja_helpers/slugify.sql **Describe alternatives you've considered** - using IDs instead of potentially problematic field names **Additional context**

Please indicate the level of urgency and business impact of this request

Are you interested in contributing to this package?

fivetran-joemarkiewicz commented 2 years ago

PR #54 will integrate this into the package. Thanks for the suggestion @fivetran-jamie!

fivetran-joemarkiewicz commented 2 years ago

The latest release of the package integrates these changes.