A very tiny fix to int_jira__issue_assign_resolution
Does this PR introduce a breaking change?
[ ] Yes (please provide breaking change details below.)
[x] No (please provide explanation how the change is non breaking below.)
It won't break anything for anybody I believe, will only make downstream models more accurate.
Is this PR in response to a previously created Issue
[ ] Yes, Issue [link issue number here]
[x] No
How did you test the PR changes?
- [ ] CircleCi
- [x] Other (please provide additional testing details below)
This is what I said on the dbt Slack: if we look at first_resolved_at for instance, my understanding is that there is always going to be a row for field_id = resolutiondate even for issues that have never been resolved, but in that case the value is null. Therefore we use the filtered CTE in order to exclude those rows, otherwise we will wrongly return an actual value for first_resolved_at when this should be null for non-resolved issues
**Select which warehouse(s) were used to test the PR**
- [ ] BigQuery
- [x] Redshift
- [ ] Snowflake
- [ ] Postgres
- [ ] Databricks
- [ ] Other (provide details below)
**Provide an emoji that best describes your current mood**
:dancer:
**Feedback**
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.
Are you a current Fivetran customer?
Thibault He, Senior BI Analyst, Onfido
What change(s) does this PR introduce?
A very tiny fix to
int_jira__issue_assign_resolutionDoes this PR introduce a breaking change?
Is this PR in response to a previously created Issue
How did you test the PR changes?
- [ ] CircleCi - [x] Other (please provide additional testing details below) This is what I said on the dbt Slack: if we look at first_resolved_at for instance, my understanding is that there is always going to be a row for field_id = resolutiondate even for issues that have never been resolved, but in that case the value is null. Therefore we use the filtered CTE in order to exclude those rows, otherwise we will wrongly return an actual value for first_resolved_at when this should be null for non-resolved issues **Select which warehouse(s) were used to test the PR** - [ ] BigQuery - [x] Redshift - [ ] Snowflake - [ ] Postgres - [ ] Databricks - [ ] Other (provide details below) **Provide an emoji that best describes your current mood** :dancer: **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.