fivetran / dbt_jira

Data models for Fivetran's Jira connector built using dbt.
https://fivetran.github.io/dbt_jira/
Apache License 2.0
8 stars 15 forks source link

current_date changed to dbt_utils.current_timestamp_in_utc #47

Closed fivetran-joemarkiewicz closed 2 years ago

fivetran-joemarkiewicz commented 2 years ago

Are you a current Fivetran customer?

Fivetran created PR

What change(s) does this PR introduce?

This PR introduces the use of the dbt_utils.current_timestamp_in_utc macro in place of the current_date warehouse function within the int_jira__issue_calendar_spine model. This is due to issues some users were experiencing with the package not providing accurate date timestamps in certain regions.

As Fivetran syncs the data in UTC it makes sense to use the UTC timezone in the calendar spine as well.

Does this PR introduce a breaking change?

This will need to result in a breaking change since the update is being made to the int_jira__issue_calendar_spine model which is incremental. As such, a --full-refresh will be needed to be executed by users in order for the change to be appropriately reflected in their output model.s

Is this PR in response to a previously created Issue

How did you test the PR changes?

- [X] CircleCi - [ ] Other (please provide additional testing details below) **Select which warehouse(s) were used to test the PR** - [X] BigQuery - [X] Redshift - [X] Snowflake - [X] Postgres - [ ] Databricks - [ ] Other (provide details below) **Provide an emoji that best describes your current mood** ⌚ **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.
fivetran-joemarkiewicz commented 2 years ago

Based off @RivkiHofman testing on their local branch, I am comfortable merging this into the release branch.