fivetran / dbt_jira

Data models for Fivetran's Jira connector built using dbt.
https://fivetran.github.io/dbt_jira/
Apache License 2.0
8 stars 15 forks source link

adjusted agg_multiselect_history incremental logi #48

Closed fivetran-joemarkiewicz closed 2 years ago

fivetran-joemarkiewicz commented 2 years ago

Are you a current Fivetran customer?

Fivetran created PR

What change(s) does this PR introduce?

This PR adjusts the incremental logic within int_jira__agg_multiselect_history to properly capture the relevant records since the last incremental run.

Does this PR introduce a breaking change?

As this PR implements an update to an incremental model, we will want to highlight this as a breaking change and for users to run --full-refresh on the first run after installing the latest version of the package.

Is this PR in response to a previously created Issue

How did you test the PR changes?

- [X] CircleCi - [ ] Other (please provide additional testing details below) **Select which warehouse(s) were used to test the PR** - [X] BigQuery - [X] Redshift - [X] Snowflake - [X] Postgres - [ ] Databricks - [ ] Other (provide details below) **Provide an emoji that best describes your current mood** 👀 **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.
fivetran-joemarkiewicz commented 2 years ago

Following the confirmation by @jcbmllgn that this works in their test environment, I am comfortable margining this on.