search

fivetran / dbt_jira

Data models for Fivetran's Jira connector built using dbt.
https://fivetran.github.io/dbt_jira/
Apache License 2.0
8 stars 15 forks source link

Fix custom field names #73

Closed crowemi closed 1 year ago

crowemi commented 2 years ago

Are you a current Fivetran customer? crowemi, Data Engineer, Subsplash

What change(s) does this PR introduce? Created set_safe_col_name macro which checks that that the issue_field_history_columns contain safe column name for the database engine (e.g. remove leading numeric character from column name)

Did you update the CHANGELOG?

Does this PR introduce a breaking change?

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

Is this PR in response to a previously created Bug or Feature Request

How did you test the PR changes?

Select which warehouse(s) were used to test the PR

Provide an emoji that best describes your current mood

🌲 **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.
crowemi commented 2 years ago

@fivetran-joemarkiewicz -- let me know if you want me to add that flag, etc. 🤷‍♂️

fivetran-joemarkiewicz commented 2 years ago

Thanks so much for opening this @crowemi!

Just to give you an ETA, we probably won't get to this until the week of 10/24 as we will be attending the Coalesce conference! I apologize for the long wait, but we will be sure to let you know if we have any feedback once we jump back in!

crowemi commented 2 years ago

No worries and no rush on my end. I moved forward with my changes internally when I initially reported. I intend on switching back once we get it merged and deployed. Have fun at Coalesce!!

crowemi commented 1 year ago

this issue was fixed here: #76