Closed fivetran-avinash closed 1 year ago
@fivetran-avinash looks good except just 1 comment I had about global variable naming!
@fivetran-reneeli @fivetran-avinash this late in the development cycle I would request to keep the variable name as it is. That variable is used extensively throughout this package and renaming it would cause quite a deal of effort. May we possibly open an FR for a future use case and keep it as is for the time being.
Are you a current Fivetran customer?
What change(s) does this PR introduce?
Did you update the CHANGELOG?
Does this PR introduce a breaking change?
jira__daily_issue_field_history
model to make sure component values are correctly joined into our issue models (#81).dbt run --full-refresh
will be required after upgrading to this version in order to capture the updates.Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
🪁 **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.