fivetran / dbt_klaviyo

https://fivetran.github.io/dbt_klaviyo/
Apache License 2.0
5 stars 6 forks source link

[Bug] Remove Klaviyo `not_null` tests for `person_id` from select models #37

Closed fivetran-avinash closed 8 months ago

fivetran-avinash commented 8 months ago

Is there an existing issue for this?

Describe the issue

Klayvio's API does return events with deactivated profiles, leading to null person_ids. While a filter has been added that customers can set to remove these events, not all customers choose to set this.

That means the following tests end up failing in the below models.

Removing these tests should resolve any test errors for our customers.

Note: There are other not_null tests for person_id in both the source/transform models that could be removed, but it seems for now these tests are passing when person_id is the initial grain rather than event data.

Relevant error log or model output

select person_id from ANALYTICS.analytics_klaviyo.klaviyo__person_campaign_flow where person_id is null

select person_id from ANALYTICS.analytics_int_klaviyo.int_klaviyo__person_metrics where person_id is null

Expected behavior

No tests should fail on our package.

dbt Project configurations

N/A

Package versions

NA

What database are you using dbt with?

bigquery

dbt Version

NA

Additional Context

No response

Are you willing to open a PR to help address this issue?