Open fivetran-joemarkiewicz opened 2 weeks ago
@fivetran-catfritz thanks for this initial review. I agree that the partition logic was not necessary and added more complexity and issues than was actually helping here since the partitioned field was not being utilized in the downstream or incremental logic. Therefore, the latest update removes this logic. I have also re-ran the validtation tests and can see the results below.
Let me know if there are any other comments or questions.
PR Overview
This PR will address the following Issue/Feature: Internally raised issue
This PR will result in the following new package version:
v0.8.0
This will be adjusting the partition granularity for all incremental models. This should only impact BigQuery users. However, it will still result in the need for a full refresh. Therefore, this should be a breaking change.
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
See below for the results of the validation tests (full refresh and incremental runs)
If you had to summarize this PR in an emoji, which would it be?
📅