fivetran-reneeli
commented
2 years ago Looks good, I just had a question for campaigns:
I noticed if we are using campaign_id and source_relation as our unique key, that results in a few duplicates.
For that staging model, if we did want all uniques we should add variation_id to the unique comb. It's not included in staging currently.
This is what I did to check all the models:
SELECT count(distinct cat) FROM
(
select concat(campaign_id, source_relation) as cat from `dbt-package-testing.dbt_joe_klaviyo.klaviyo__campaigns`
);
SELECT count( cat) FROM
(
select concat(campaign_id, source_relation) as cat from `dbt-package-testing.dbt_joe_klaviyo.klaviyo__campaigns`
);
-- events: 135603607, 135603607
-- persons: 399447, 399447
-- campaigns: 892, 1448
-- flows: 24, 24
fivetran-joemarkiewicz
Are you a current Fivetran customer?
Fivetran created PR
What change(s) does this PR introduce?
This PR includes the following updates:
unione_schemas/databasesvariables to instead byklaviyo_union_schemas/databases. This way the variables are klaviyo specific. PR #10stg_klaviyo__eventsto be used in downstream models.Does this PR introduce a breaking change?
Variable name changes result in breaking changes
Is this PR in response to a previously created Issue
How did you test the PR changes?
- [X] CircleCi - [ ] Other (please provide additional testing details below) **Select which warehouse(s) were used to test the PR** - [X] BigQuery - [X] Redshift - [X] Snowflake - [X] Postgres - [ ] Databricks - [ ] Other (provide details below) **Provide an emoji that best describes your current mood** 📧 **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.