fivetran / dbt_klaviyo_source

https://fivetran.github.io/dbt_klaviyo_source/
Apache License 2.0
2 stars 5 forks source link

Fix `property_value` in `stg_klaviyo__event.sql` #21

Closed vnguyen12 closed 4 months ago

vnguyen12 commented 5 months ago

The field property_value does not enforce float type and can contain non numerical characters, for example $1,234.56. This leads any downstream models, such as int_klaviyo__event_attribution, that expect property_value to be of float type to fail

Please provide your name and company Vy Dutch Pets

Link the issue/feature request which this PR is meant to address

https://github.com/fivetran/dbt_klaviyo_source/issues/20

Detail what changes this PR introduces and how this addresses the issue/feature request linked above. Remove any non-numerical characters that property_value might have using regexp_replace

How did you validate the changes introduced within this PR? Re-built the model with dbt run -select stg_klaviyo__event ![Uploading Screenshot 2024-04-04 at 1.43.01 PM.png…]()

Which warehouse did you use to develop these changes? Snowflake

Did you update the CHANGELOG?

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

Provide an emoji that best describes your current mood

:dancer: **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next. **PR Template** - [Community Pull Request Template](?expand=1&template=pull_request_template.md) (default) - [Maintainer Pull Request Template](?expand=1&template=maintainer_pull_request_template.md) (to be used by maintainers)