fivetran / dbt_klaviyo_source

https://fivetran.github.io/dbt_klaviyo_source/
Apache License 2.0
2 stars 5 forks source link

Bugfix/property value as numeric #22

Closed fivetran-avinash closed 6 months ago

fivetran-avinash commented 6 months ago

PR Overview

This PR will address the following Issue/Feature: [#20]

This PR will result in the following new package version: 0.7.1

Not a breaking change--it should update field values but not the name itself.

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

🪲 Bug Fixes 🪛

🚘 Under the Hood 🚘

Contributors

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

Before marking this PR as "ready for review" the following have been applied:

Detailed Validation

Please share any and all of your validation steps:

We tested across all destinations that (1) the seed file is showing values of various types (normal numerical, numeric type with a $ type, null value), and then made sure that the regex_replace removed the $ expression and left only the numeric values.