fivetran / dbt_linkedin

Fivetran's Linkedin Ads dbt package
https://fivetran.github.io/dbt_linkedin/
Apache License 2.0
2 stars 12 forks source link

fix: add missing `is_latest_version` filter in `linkedin_ads__url_report` CTE #26

Closed aleix-cd closed 1 year ago

aleix-cd commented 1 year ago

Are you a current Fivetran customer?

Yes. Aleix Cubel, Analytics Engineer at Capdesk from Carta

What change(s) does this PR introduce?

Adding a missing is_latest_version filter within the linkedin_ads__url_report model (specifically, in the creative CTE)

Did you update the CHANGELOG?

Does this PR introduce a breaking change?

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

Is this PR in response to a previously created Bug or Feature Request

How did you test the PR changes?

Select which warehouse(s) were used to test the PR

Provide an emoji that best describes your current mood

:dancer: **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.
aleix-cd commented 1 year ago

Thanks so much for opening this PR @aleix-cd 🏅

This change looks good to me! Before this will be good to approve and merge there are two final updates we will need to apply to the package:

  • [ ] Update the dbt version to be 0.6.1 within the dbt_project.yml and integration_tests/dbt_project.yml files.
  • [ ] Create a new CHANGELOG entry for v0.6.1 in the same format as the other entries. You will want to add a bugfix section detailing the update you applied here and a link to your PR. You can also add a Contributor section to highlight your contribution 😄

Let me know if you need help with any of these!

This has now been done, @fivetran-joemarkiewicz. Let me know if you feel there's anything missing!