search

fivetran / dbt_linkedin

Fivetran's Linkedin Ads dbt package
https://fivetran.github.io/dbt_linkedin/
Apache License 2.0
2 stars 12 forks source link

[Feature] LinkedIn API Changes #27

Closed fivetran-joemarkiewicz closed 1 year ago

fivetran-joemarkiewicz commented 1 year ago

Is there an existing feature request for this?

Describe the Feature

The LinkedIn API has changed and a rollout of these changes within the Fivetran connector will impact the schema which this package is currently using. This will result in a breaking change and need to be updated to ensure LinkedIn users are getting the most up to date and accurate data from their Fivetran LinkedIn connector.

Describe alternatives you've considered

Please see internal notes for more details on what updates will most likely need to be rolled out. This is still in a discovery phase and more details will be shared as we learn more.

Are you interested in contributing this feature?

Anything else?

We will need to understand if these API changes are being rolled out to all Fivetran LinkedIn customers or just a few periodically, this will impact our approach to resolving the API differences within this package and the source.

This update should also address Issue #5

brendangeisler commented 1 year ago

Hello - Just reporting that today I'm receiving an error that the linkedin_ads__creative_report is failing on the creative_id not null tests. Hoping that it's addressed with this issue.

fivetran-joemarkiewicz commented 1 year ago

Hi @brendangeisler thanks for chiming in here! We actually have a working PR that may address the issue you are experiencing (see the PR #28 for more details). If you are able, it would be incredibly helpful if you would be able to test the branch on your data to see if it addresses the API changes. You can test this branch using the below package version in your packages.yml

packages:
  - git: https://github.com/fivetran/dbt_linkedin.git
    revision: feature/linkedin-api-updates-2023
    warn-unpinned: false
brendangeisler commented 1 year ago

Hi @fivetran-joemarkiewicz - I was able to test the package you recommended above against our production data, and can confirm that I no longer trip over the null tests in the STG_LINKEDIN_ADS__CAMPAIGN_HISTORY model.

Looking forward to when this is released.

fivetran-joemarkiewicz commented 1 year ago

Hi @brendangeisler that's great to hear! We actually were able to cut the release at the tail end of last week. You should be able to upgrade the package and see the solution is live in the latest version.

As such, I will close out this issue. Please feel free to reopen if the issue persists.