[Bug] Linkedin Ads URL not showing up due to API changes

ryan-loveland commented 3 weeks ago

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the issue

I am using the dbt ad_reporting package and while testing I noticed the ad_reporting__url_report has no data for LinkedIn. Looking at the underlying models - the URL value is being pulled and parsed from the creative_history.click_uri value which doesn't appear to exist in our connector.

I reached out to support and they told me that there was an API change:

Your click_uri should now be spotlight_landing_page and text_ad_landing_page in the CREATIVE_HISTORY table based on the LinkedIn API Creative migration.

This would mean the models starting from the source model: https://github.com/fivetran/dbt_linkedin_source/blob/main/models/stg_linkedin_ads__creative_history.sql and all that rely on it would need to be updated to ensure the URL is being passed to the final ad_report model.

Relevant error log or model output

No response

Expected behavior

The dbt package uses the updated fields to support the final URL report.

dbt Project configurations

NA

Package versions

package: fivetran/ad_reporting version: 1.7.1

What database are you using dbt with?

snowflake

dbt Version

latest version

Additional Context

No response

Are you willing to open a PR to help address this issue?

[ ] Yes.
[ ] Yes, but I will need assistance and will schedule time during our office hours for guidance
[X] No.

fivetran-catfritz commented 3 weeks ago

Hi @ryan-loveland thank you for bringing this to our attention! A quick question for you while I look into this--when did you first set up your Linkedin Ads connector? Also out of curiosity, do you have the column creative_history.click_uri with no data populated, or do you not have this column at all?

ryan-loveland commented 3 weeks ago

@fivetran-catfritz

I added the LinkedIn Ads connector on April 30th 2024.
I do not see the creative_history.click_uri as a column in the connector Schema.

fivetran-catfritz commented 3 weeks ago

@ryan-loveland thank you for the information. This is definitely something we want to update on our end. I'll discuss this internally to get a better sense of when we plan to take this on, so stay tuned!

fivetran-catfritz commented 2 weeks ago

Hi @ryan-loveland we still need to verify a few items in order to create the right fix for all customers, but in the meantime I created a test branch you can try for your case. Would you be able to give this a run and see if the data is brought through correctly? You can install the test branch by replacing the linkedin lines in your packages.yml with:

packages:
  - git: https://github.com/fivetran/dbt_linkedin.git
    revision: feature/click-uri-deprecation
    warn-unpinned: false

Let me know how it goes!

fivetran-catfritz commented 1 week ago

Hi @ryan-loveland hope you had a nice weekend! Just checking in if you're interested in testing out the release branch I mentioned?

georgios-ntanakas commented 5 days ago

Hi there! We are also facing the same issue. Fivetran connector added in March 14 and the click_uri field exists in the table but is null everywhere. Of course, the field cannot be seen in the Schema tab of the Fivetran connector. @fivetran-catfritz I had the look at the branch but it only seems to update 2 yml files. Wouldn't an update to the ad_reporting__url_report model be necessary to fix this?

fivetran-joemarkiewicz commented 4 days ago

Hi @georgios-ntanakas, thanks for chiming in on this ticket and sharing you are also experiencing a similar issue.

In regards to the branch @fivetran-catfritz shared, the primary changes actually take place in the dbt_linkedin_source package branch which this development branch is now referencing. You can see the source changes here.

If you are currently using the Fivetran Ad Reporting package and would like to test the branch @fivetran-catfritz suggested, then you can attempt to use the below Ad Reporting branch which installs the above Linkedin Ads development changes which include the click_uri field change.

packages:
  - git: https://github.com/fivetran/dbt_ad_reporting.git
    revision: feature/click-uri-deprecation
    warn-unpinned: false

Let me know if you are able to test either the LinkedIn or Ad Reporting development branches and if this address this highlighted issue. Thanks!

fivetran / dbt_linkedin