fivetran / dbt_linkedin

Fivetran's Linkedin Ads dbt package
https://fivetran.github.io/dbt_linkedin/
Apache License 2.0
2 stars 12 forks source link

[Bug] Avoid duplicate column errors for users already including `conversion_value_in_local_currency` as a passthrough field #40

Closed fivetran-jamie closed 1 week ago

fivetran-jamie commented 4 weeks ago

Is there an existing issue for this?

Describe the issue

The recent conversions release is intended to be backwards compatible and not cause any errors for folks who have already been including conversions via our existing passthrough column framework. For the most this was achieved, but we missed the case of conversion_value_in_local_currency.

Relevant error log or model output

Database Error in model linkedin_ads__account_report (models/linkedin_ads__account_report.sql)
  CREATE TABLE has columns with duplicate name conversion_value_in_local_currency at [15:1]
  compiled code at target/run/linkedin/models/linkedin_ads__account_report.sql

Expected behavior

Should run without error. conversion_value_in_local_currency is included in my model

Possible solution

Adapt solution from Snapchat ads

dbt Project configurations

vars:
  linkedin_ads__campaign_passthrough_metrics:
    - name: 'conversion_value_in_local_currency'

Package versions

v0.9.0

What database are you using dbt with?

postgres, redshift, snowflake, bigquery, databricks

How are you running this dbt package?

dbt Core™

dbt Version

Core:

Plugins:

Additional Context

No response

Are you willing to open a PR to help address this issue?

fivetran-joemarkiewicz commented 1 week ago

Closing this issue as it's been addressed in the latest release.